[RFC] Integrate wolfHAL #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

AlexLanzano wants to merge 5 commits into wolfSSL:master from AlexLanzano:wolfHAL-integration

Member

AlexLanzano commented Jan 26, 2026

I hacked together this quick wolfHAL integration using the current implementation of wolfHAL that I already worked on.

This PR is more-so meant for discussion/buy-in on how wolfHAL should be used within wolfBoot rather than getting this PR merged in.

Here's an overview of what I did:

Modify Makefiles to support new wolfhal TARGET
Add example config stm32wb-wolfhal.config
Add new wolfHAL config directory ./config/wolfHAL/
- Contains board config .c file
- Contains wolfHAL build config .mk file
Add generic wolfhal.c that provides the wolfBoot hal_* api functions using wolfHAL
Add generic uart_drv_wolfhal.c that provides the wolfBoot uart_* api functions using wolfHAL
Add generic app_wolfhal.c that provides a test app using wolfHAL

I've tested this on the stm32wb nucleo board and I'm able to boot fully into the target app

Here is the wolfHAL repo I used to build this https://github.com/AlexLanzano/wolfHAL/tree/wolfboot-integration
As you can see the design is unchanged from what I presented in the meeting. SInce I had the stm32wb drivers already done in this design I figured it would be best to just give the integration a shot and have you guys point out the specific parts you dont like

AlexLanzano requested review from bigbrett, danielinux, dgarske and rizlik

January 26, 2026 22:54

AlexLanzano self-assigned this

danielinux requested changes

View reviewed changes

Member

danielinux left a comment •

edited

Loading

some errors must be propagated better
UART drivers inclusion in bootloader should depend on whether UART is enabled in the config (default: off)
No tests: at least one build test is needed, but at this stage it would also be useful to have a comparison of the footprint for the extra added layer. Please check footprint test, build on the same target/compiler with wolfHAL and compare footprints
wrong submodule URL: it should be https://github.com/wolfssl/wolfhal, not git@github.com ...

config/wolfHAL/stm32wb55_nucleo.c Outdated

		@@ -0,0 +1,101 @@
		#include <wolfHAL/platform/st/stm32wb55xx.h>

		whal_StRcc_PeriphClk periphClkEn[] =

Member

danielinux Jan 27, 2026

static

Member Author

AlexLanzano Jan 28, 2026

These can't be static since they are externed in both hal/wolfhal.c and the test app

config/wolfHAL/stm32wb55_nucleo.c Outdated

+                  WHAL_ST_RCC_PERIPH_FLASH,
+              };
+              whal_Clock wbClock = {

Member

danielinux Jan 27, 2026

static

Member Author

AlexLanzano Feb 2, 2026

These can't be static since they are externed in both hal/wolfhal.c and the test app

config/wolfHAL/stm32wb55_nucleo.c Outdated

+                  },
+              };
+              whal_Gpio wbGpio = {

Member

danielinux Jan 27, 2026

static

Member Author

AlexLanzano Feb 2, 2026

These can't be static since they are externed in both hal/wolfhal.c and the test app

config/wolfHAL/stm32wb55_nucleo.c Outdated

+                  .pinCount = 3,
+              };
+              whal_Uart wbUart = {

Member

danielinux Jan 27, 2026

static

Member Author

AlexLanzano Feb 2, 2026

These can't be static since they are externed in both hal/wolfhal.c and the test app

config/wolfHAL/stm32wb55_nucleo.c Outdated

+                  },
+              };
+              whal_Flash wbFlash = {

Member

danielinux Jan 27, 2026

static

Member Author

AlexLanzano Feb 2, 2026

These can't be static since they are externed in both hal/wolfhal.c and the test app

config/wolfHAL/stm32wb55_nucleo.mk Outdated

Member

danielinux Jan 27, 2026

inclusion of st_uart.o should be conditional to config (default is no uart enabled in bootloader)

Member Author

AlexLanzano Feb 2, 2026

Fixed

hal/uart/uart_drv_wolfhal.c Show resolved Hide resolved

hal/uart/uart_drv_wolfhal.c Outdated

+              int uart_rx(uint8_t *c)
+              {
+                  whal_Uart_Recv(&wbUart, c, 1);
+                  /* ALEX NOTE: this function also returns zero if no data is available... */

Member

danielinux Jan 27, 2026

a better handling of whal_ return values is required

Member Author

AlexLanzano Feb 2, 2026

Fixed

hal/wolfhal.c Show resolved Hide resolved


          Integrate wolfHAL

3e80589

AlexLanzano force-pushed the wolfHAL-integration branch from ab7ccb4 to 3e80589 Compare

January 27, 2026 15:31

AlexLanzano added 2 commits

February 1, 2026 14:11


          Move wolfHAL board config and build file to hal/. Optimize wolfHAL bu…

55979c2

…ild image


          Update wolfHAL driver name. Add option to not compile in wolfhal gpio

9ede286

AlexLanzano force-pushed the wolfHAL-integration branch 2 times, most recently from 0743918 to 54cdcf8 Compare

February 2, 2026 16:02


          Add build test

54cdcf8

AlexLanzano requested a review from danielinux

February 2, 2026 16:03

rizlik reviewed

View reviewed changes

Contributor

rizlik left a comment

This is just a partial review, I need to dig into the wolfHAL design yet.

config/examples/stm32wb-wolfhal.config

Comment on lines +11 to +15

+              WOLFHAL_TARGET=stm32wb
+              WOLFHAL_BOARD=stm32wb55_nucleo
+              WOLFHAL_FLASH_START=0x08000000
+              WOLFHAL_FLASH_SIZE=0x100000
+              WOLFHAL_NO_GPIO=1

Contributor

rizlik Feb 5, 2026

I'm not sure that WOLFHAL configuration must lives in the same configuration of wolfBoot. I would like to have a better separation. I'm not sure how to drive the wolfBoot toolchain though, probably there is the need of some integration in arch.mk and similar

Member Author

AlexLanzano Feb 5, 2026

These are technically wolfBoot configuration options for the wolfBoot wolfHAL target. Maybe we need better naming for these?

config/examples/stm32wb.config Outdated

               WOLFBOOT_SECTOR_SIZE=0x1000
               WOLFBOOT_PARTITION_SIZE=0x20000
-              WOLFBOOT_PARTITION_BOOT_ADDRESS=0x08008000
+              WOLFBOOT_PARTITION_BOOT_ADDRESS=0x08010000

Contributor

rizlik Feb 5, 2026

is this unrelated to wolfHAL?

Member Author

AlexLanzano Feb 5, 2026

Will remove. This was to have enough room for debug symbols.

Member Author

AlexLanzano Feb 9, 2026

Fixed

hal/uart/uart_drv_wolfhal.c Outdated

+              #include <stdint.h>
+              #include <wolfHAL/wolfHAL.h>
+              extern whal_Uart wbUart;

Contributor

rizlik Feb 5, 2026

NIT: if we really have an "magical" external whal_Uart, maybe we can either make it implicit or, better imo, add a whal_Uart whal_Uart_Get_Port(uint32_t id) or similar.
In general while I think the library must support compile time configuration and object, it might be nice to give a little flexibility so that can be used also in context where you want to dynamically create objects or configure the objects differently.

Member Author

AlexLanzano Feb 5, 2026

Im hesitant to add Get functions like whal_Uart_GetPort since that would increase image size.

Maybe I could name the externed variables better to make it more explicit of what they are?
I.E. g_whalUart or g_boardUart?

Member Author

AlexLanzano Feb 9, 2026

Renamed to g_whal*

hal/wolfHAL/stm32wb55_nucleo.mk Outdated

Comment on lines 8 to 9

		ifeq ($(DEBUG_UART),1)
		endif

Contributor

rizlik Feb 5, 2026

empty?

Member Author

AlexLanzano Feb 9, 2026

Fixed


          Address comments

10c437f

AlexLanzano requested a review from rizlik

February 9, 2026 14:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet